[DSL] Refactor effective data retention #105750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarouli
added
>refactoring
:Data Management/Data streams
elasticsearchmachine
added
v8.14.0
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
@elasticmachine update branch |
masseyke
reviewed
Mar 4, 2024
| IndexMetadata.DownsampleTaskStatus downsampleStatus = INDEX_DOWNSAMPLE_STATUS.get(backingIndex.getSettings()); | ||
| // we don't want to delete the source index if they have an in-progress downsampling operation because the | ||
| // target downsample index will remain in the system as a standalone index | ||
| TimeValue effectiveDataRetention = dataStream.getLifecycle().getEffectiveDataRetention(); |
There was a problem hiding this comment.
Just curious if there's a reason you moved this inside the for loop -- my understanding is that it's going to be the same for every index in the datastream, right? I assume this will always be a fairly cheap calculation, but any reason to do it repeatedly?
masseyke
approved these changes
Mar 4, 2024
|
@elasticmachine branch update |
|
Existing test failure: #105922 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we refactor
DataStreamLifecycleto facilitate the data stream lifecycle global settings. We introduce two methods that retrieve the data retention. Currently, they have the exact same implementation but in the future they will differ.getDataStreamRetention: this is the retention a user configured on the data stream level upon creation or via thePUT _data_stream/{data-stream}/_lifecycleAPI.getEffectiveDataRetention: This is the retention that will be applied by DSL on the data stream. Right now it's just calling thegetDataStreamRetentionbut in the future it will take into consideration also the global retention.The benefit of this work is to enable us to semantically distinguish the two retentions in a manageable PR.